Skip to content

Option to check whole repository/directory #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
r-sharp wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Option to check whole repository/directory #180

r-sharp wants to merge 14 commits into from

Conversation

@r-sharp
Copy link
Contributor

@r-sharp r-sharp commented Feb 5, 2026 •
edited
Loading

PR Summary

Sci/Tech Reviewer: @Pierre-siddall
Code Reviewer: @jennyhickson

A change to add a command line argument whichrather than checking with a CMS for a list of changed files, uses glob to assemble a list of all files within a direcotry (or local repository clone)
As such, adds a block for the new, logical, argument.
Creates a new subroutine to decide whether to ask a CMS or use glob.
Refactors the bit that used to output info about the branch and the files found to within the routine that decides which CMS to use before passing the CMS object back to the new routine which creates the list of files to check.

Still stacking those PRs

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Change run, on command line of VDI, against other peoples ukca and um branches both with and without --fullcheck. The results were as expected.

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

AI used (GitHub Copilot) as it is enabled to provide inline hinting and completion. It's responsibe for those two horrendously verbose (by even my standards) docstrings, which I accepted purely for amusment's sake.

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@r-sharp r-sharp added this to the Spring 2026 milestone Feb 5, 2026
@r-sharp r-sharp marked this pull request as ready for review February 9, 2026 12:24
@r-sharp r-sharp added the blocked See Description for blocking PR label Feb 9, 2026
This was referenced Feb 9, 2026
Open
Merged
r-sharp and others added 2 commits February 9, 2026 18:28
@r-sharp @Pierre-siddall @ericaneininger
Tweaks to get VSCode's internal linters to quit whinging and make the… (
d8f0206 
MetOffice#173)

* Tweaks to get VSCode's internal linters to quit whinging and make the ToDo plugin work nicely.

* Touch O Tidying and ToDo commenting.

* reviewer request to Update script_umdp3_checker/umdp3_conformance.py

Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>

* Update script_umdp3_checker/umdp3_checker_rules.py

Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>

* Update script_umdp3_checker/umdp3_checker_rules.py

Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>

* Update script_umdp3_checker/umdp3_checker_rules.py

Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>

* Update script_umdp3_checker/umdp3_checker_rules.py

Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>

* Update script_umdp3_checker/umdp3_checker_rules.py

Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>

* Rreviwer requested changes that I was unable to commit via GitHub's web interface

---------

Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com>
Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>
@r-sharp
Merge branch 'main' into scour_whole_repository
f8722b9
@r-sharp r-sharp removed the blocked See Description for blocking PR label Feb 9, 2026
Pierre-siddall
Pierre-siddall requested changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@Pierre-siddall Pierre-siddall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically speaking this mostly looks good to head onto code review for me. I just have a couple of really tiny suggestions when it comes to documentation and allocating a small amount of redundant memory. If the checkers array is a placeholder to prompt you later on feel free to leave it there, but I thought I'd flag it as I was unsure of it's intent.

script_umdp3_checker/umdp3_conformance.py
@@ -1 +1 @@
import subprocess
Copy link
Contributor

@Pierre-siddall Pierre-siddall Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this file has been coded with AI it need to have the following statement at the top in line with the AI policy

Suggested change
# Some of the content of this file has been produced with the assistance of
<Generative AI tool name>."
import subprocess

Copy link
Contributor Author

@r-sharp r-sharp Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree.
some AI "code completion" suggestions were accepted. Had it not made those suggestions, I would have typed the same code in manually.
If this constitutes assistance of generative AI, where do you draw the line ? linters correcting syntax ? spell checkers correcting spelling ?
I had assumed "produced with the assistance of" referred to instances where the AI was prompted to produce something specific from thin air. e.g. "create a routine to do ", whereas code completion is barely any more involved than variable name completion. More than half the time whatever it suggests has to be ignored or edited anyway, so the addition of some closing quotes or curly braces is unlikely to cause IPR concerns.

r-sharp and others added 2 commits February 13, 2026 10:44
@r-sharp @Pierre-siddall
Update script_umdp3_checker/umdp3_conformance.py
7f054da 
Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com>
@r-sharp @Pierre-siddall
remove redundent line
ce61de7 
Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-siddall Pierre-siddall Awaiting requested review from Pierre-siddall

Requested changes must be addressed to merge this pull request.

Assignees

@r-sharp r-sharp

Labels

None yet

Projects

None yet

Milestone

Spring 2026

Development

Successfully merging this pull request may close these issues.

2 participants

@r-sharp @Pierre-siddall